search

airbnb / interferon

Signaling you about infrastructure or application issues
MIT License
239 stars 44 forks source link

method need return value in graceful shutdown #9

Closed ziliangpeng closed 8 years ago

ziliangpeng commented 8 years ago

In v0.0.8 create_alerts does not return value in grace shutdown mode, which will crash the program.

to @igor47 @jianAir

igor47 commented 8 years ago

do you want to add tests to catch this regression?

jianAir commented 8 years ago

let's bump it to 0.0.9 It's a bug fix that will apply to production.