search

airbnb / knowledge-repo

A next-generation curated knowledge sharing platform for data scientists and other technical professions.
Apache License 2.0
5.48k stars 687 forks source link

Support Python >= 3.6 #547

Closed naoyak closed 4 years ago

naoyak commented 4 years ago

Description of changeset

Proposing dropping support for Python versions < 3.6 to reduce maintenance overhead and unlock some dependency upgrades (https://github.com/airbnb/knowledge-repo/pull/300#commitcomment-39416214).

Test Plan:

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.766 completed (commit https://github.com/airbnb/knowledge-repo/commit/2e49facae3 by @naoyak)

AppVeyorBot commented 4 years ago

:x: Build knowledge-repo 1.0.767 failed (commit https://github.com/airbnb/knowledge-repo/commit/889fc41d2e by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.768 completed (commit https://github.com/airbnb/knowledge-repo/commit/caec885738 by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.769 completed (commit https://github.com/airbnb/knowledge-repo/commit/566fb150eb by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.770 completed (commit https://github.com/airbnb/knowledge-repo/commit/05bc6cc875 by @naoyak)

bulam commented 4 years ago

@naoyak Thanks for putting it in! I think this LGTM. @etr2460 Any thoughts?

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.777 completed (commit https://github.com/airbnb/knowledge-repo/commit/156523442b by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.778 completed (commit https://github.com/airbnb/knowledge-repo/commit/00fa310f8b by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.779 completed (commit https://github.com/airbnb/knowledge-repo/commit/4f93017003 by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.800 completed (commit https://github.com/airbnb/knowledge-repo/commit/f73aded24d by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.801 completed (commit https://github.com/airbnb/knowledge-repo/commit/b43e39c1e7 by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.802 completed (commit https://github.com/airbnb/knowledge-repo/commit/04ca2433e1 by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.803 completed (commit https://github.com/airbnb/knowledge-repo/commit/665872be1a by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.805 completed (commit https://github.com/airbnb/knowledge-repo/commit/6d7635c6c4 by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.807 completed (commit https://github.com/airbnb/knowledge-repo/commit/45fed5a46a by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.808 completed (commit https://github.com/airbnb/knowledge-repo/commit/ccf7957dab by @naoyak)

AppVeyorBot commented 4 years ago

:x: Build knowledge-repo 1.0.809 failed (commit https://github.com/airbnb/knowledge-repo/commit/088f7f448e by @naoyak)

AppVeyorBot commented 4 years ago

:x: Build knowledge-repo 1.0.810 failed (commit https://github.com/airbnb/knowledge-repo/commit/3b93a6b9ee by @naoyak)

AppVeyorBot commented 4 years ago

:x: Build knowledge-repo 1.0.811 failed (commit https://github.com/airbnb/knowledge-repo/commit/206b15ed3b by @naoyak)

AppVeyorBot commented 4 years ago

:x: Build knowledge-repo 1.0.812 failed (commit https://github.com/airbnb/knowledge-repo/commit/7b47ca9e0a by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.813 completed (commit https://github.com/airbnb/knowledge-repo/commit/96277786bb by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.814 completed (commit https://github.com/airbnb/knowledge-repo/commit/c594be0e9c by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.815 completed (commit https://github.com/airbnb/knowledge-repo/commit/4f3b342962 by @naoyak)

etr2460 commented 4 years ago

@john-bodley or @serenajiang, would you mind taking a look at this?

bulam commented 4 years ago

@naoyak I think there might be a lot of users using Python 2.7 on their own computers. If they try to add posts to the repo using the older version of the knowledge repo compatible with Python 2.7 do you think there could be compatability issues?

naoyak commented 4 years ago

@bulam personally I think it's reasonable to require Python 3 for those who want to use the latest version of KR, given that Python 2 has been EOL'd and most major libraries have dropped support. Perhaps it makes sense to ship this in a new major/minor release along with your styling revamp in #548?

john-bodley commented 4 years ago

@bulam I agree with @naoyak here. It's pretty easy for users to support multiple versions of Python locally via pyenv.

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.816 completed (commit https://github.com/airbnb/knowledge-repo/commit/aeab224826 by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.817 completed (commit https://github.com/airbnb/knowledge-repo/commit/2a5a84271f by @naoyak)

AppVeyorBot commented 4 years ago

:white_check_mark: Build knowledge-repo 1.0.818 completed (commit https://github.com/airbnb/knowledge-repo/commit/05e08b5f7f by @naoyak)