search

airbnb / knowledge-repo

A next-generation curated knowledge sharing platform for data scientists and other technical professions.
Apache License 2.0
5.48k stars 687 forks source link

Removing read of knowledge repo config file off default branch of master #571

Closed e-m-albright closed 2 years ago

e-m-albright commented 4 years ago

Fixes #569

Description of changeset:

It looks like you're reading the state of the config file of the knowledge repo off of the target branch which is hardcoded to default as master before there's any room to update the preference of what branch to use.

As a simple fix perhaps it's best to read the state of the config for the knowledge repo of whatever the active branch is instead? This alleviates the breakage when there is no master branch to check the file out from in the git of the knowledge repo.

Test Plan:

Tried pytest, tried bash run_tests.sh, neither worked. I'm not sure if the issues are environmental and I should be using another tool to aid with them.

Would love to know how to help further! Figure this is at least a good starting point to help me learn more about your systems.

bulam commented 4 years ago

Thanks for the contribution! Will take a look when I get a chance :)