airbnb / lottie-android

Render After Effects animations natively on Android and iOS, Web, and React Native
http://airbnb.io/lottie/
Apache License 2.0
35.03k stars 5.41k forks source link

Animation rendering issue on bazier curves once rotated #2149

Closed StefanoBozzoni closed 2 years ago

StefanoBozzoni commented 2 years ago

The animation of a circle with an exclamation mark inside it was working on version 4.21 but not after that, actually version 5.2.0 is still not working. What happens is that the circle surrounding the exlamation mark becomes a rhombus on Android device.

I have digged a little more inside the issue and it seems, but i am not a lottie expert, that when the layer that contains the circle rotates its content by 90 degrees to change the animation starting point, this rotation have an effect on the bezier curves that form the circle, changing its shape. This doesn't happen on similar animations that doesn't use this rotation. It is only a supposition.

To reproduce the issue just play the icona_ko animation, that i have attacched here, on an android device and you will see the difference with the lottie online player. I have attacched also a similar animation that instead works correctly, it's name is icona_ko_working. animations.zip

gpeal commented 2 years ago

I fixed the underlying issue here but FWIW, it was caused because there was a rounded corners modifier that was applied to a shape that didn't actually have any corners to round (the shape itself had rounded corners).

StefanoBozzoni commented 2 years ago

thank you so much !

Il giorno lun 14 nov 2022 alle ore 06:52 Gabriel Peal < @.***> ha scritto:

I fixed the underlying issue here but FWIW, it was caused because there was a rounded corners modifier that was applied to a shape that didn't actually have any corners to round (the shape itself had rounded corners).

— Reply to this email directly, view it on GitHub https://github.com/airbnb/lottie-android/issues/2149#issuecomment-1313131085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHTEGB5NSHAEWDOCEGPJLT3WIHHTDANCNFSM6AAAAAARPZFMXQ . You are receiving this because you authored the thread.Message ID: @.***>