airbnb / lottie-android

Render After Effects animations natively on Android and iOS, Web, and React Native
http://airbnb.io/lottie/
Apache License 2.0
34.92k stars 5.4k forks source link

Prevent trace strings from getting created when tracing is disabled #2494

Closed uni-cstar closed 4 months ago

uni-cstar commented 4 months ago

issue#2493

uni-cstar commented 4 months ago

I fixed it.

At 2024-04-13 04:20:18, "Gabriel Peal" @.***> wrote:

@gpeal commented on this pull request.

In lottie/src/main/java/com/airbnb/lottie/animation/keyframe/BaseKeyframeAnimation.java:

@@ -112,8 +128,7 @@ protected float getInterpolatedCurrentKeyframeProgress() { Keyframe keyframe = getCurrentKeyframe(); // Keyframe should not be null here but there seems to be a Xiaomi Android 10 specific crash. // https://github.com/airbnb/lottie-android/issues/2050

This comment is specifically referring to the addition you made here for keyframe.interpolator == null which seems unrelated to the rest of the code in this PR.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

github-actions[bot] commented 4 months ago

Snapshot Tests API 23: Report Diff API 31: Report Diff