search

airbnb / lottie-android

Render After Effects animations natively on Android and iOS, Web, and React Native
http://airbnb.io/lottie/
Apache License 2.0
34.92k stars 5.4k forks source link

Add generalized Lottie Feature Flags API #2512

Closed jbeta51 closed 1 month ago

jbeta51 commented 2 months ago

Currently there are individual methods for enabling and disabling Merge Paths in Lottie. This PR aims to generalize these functions as we consider adding more features guarded behind opt-in flags.

See https://github.com/jbeta51/lottie-android/pull/2 for draft comments.

github-actions[bot] commented 2 months ago

Snapshot Tests API 23: Report Diff API 31: Report Diff

github-actions[bot] commented 2 months ago

Snapshot Tests API 23: Report Diff API 31: Report Diff

github-actions[bot] commented 2 months ago

Snapshot Tests API 23: Report Diff API 31: Report Diff

github-actions[bot] commented 1 month ago

Snapshot Tests API 23: Report Diff API 31: Report Diff

github-actions[bot] commented 1 month ago

Snapshot Tests API 23: Report Diff API 31: Report Diff

jbeta51 commented 1 month ago

Looks good! Would you like to add this API to lottie-compose as well or would you like me to?

I could add it, but I also thought that was covered by adding it to LottiePainter.kt and LottieAnimation.kt, so I'd need to be pointed in the right direction. We can followup later or in another PR.

gpeal commented 1 month ago

Looks good! Would you like to add this API to lottie-compose as well or would you like me to?

I could add it, but I also thought that was covered by adding it to LottiePainter.kt and LottieAnimation.kt, so I'd need to be pointed in the right direction. We can followup later or in another PR.

I'll add support for Compose in a bit https://github.com/airbnb/lottie-android/issues/2515