airbnb / lottie-ios

An iOS library to natively render After Effects vector animations
http://airbnb.io/lottie/
Apache License 2.0
25.65k stars 3.74k forks source link

3.4.1 won't install via Carthage ("xcodebuild timed out while trying to read Lottie.xcworkspace") #1709

Closed stevelandeyasana closed 2 years ago

stevelandeyasana commented 2 years ago

Which Version of Lottie are you using?

Lottie 3.4.1

Expected Behavior

Carthage install works

Actual Behavior

mint run carthage update --platform iOS --use-xcframeworks --use-ssh --no-use-binaries --cache-builds
...
*** Fetching lottie-ios
...
*** Checking out lottie-ios at "3.4.1"
...
*** xcodebuild output can be found in /var/folders/9r/rlljjbhx6sngfnfbdrsdt6rr0000gq/T/carthage-xcodebuild.BitVMM.log
...
*** Invalid cache found for lottie-ios, rebuilding with all downstream dependencies
...
xcodebuild timed out while trying to read Lottie.xcworkspace 😭

This issue does not occur on 3.4.0.

Animation JSON

calda commented 2 years ago

Could you share a sample project that reproduces this issue?

stevelandeyasana commented 2 years ago

I'll consider finding the time in the future. But this is purely running in Carthage, not building my project, so I'm not sure it would really be helpful.

Some googling suggests that if a project has SPM dependencies (which lottie does) and the user has a slow internet connection (which I do), Carthage can time out due to xcodebuild needing to fetch the SPM dependencies. https://github.com/realm/realm-swift/issues/6549

To try to reproduce, consider installing Network Link Conditioner and installing on a simulated slower network.

calda commented 2 years ago

Does this still happen if you point carthage to master instead of 3.4.1? We briefly had a large number of transitive dependencies in our Package.resolved which are present in 3.4.1 but no longer present on master. That change should reduce the number of repos that need to be cloned, which may fix this issue.

mrvetz commented 2 years ago

I have a similar problem with the 3.4.1 version. Running Xcode 13.4.1, Carthage 0.38.0

Here's the log. Checking out lottie-ios at "3.4.1" xcodebuild output can be found in /var/folders/kw/2l2lr0kj2cg8z3fyflb32_brbh_c_g/T/carthage-xcodebuild.2aB1Tu.log A shell task (/usr/bin/xcrun xcodebuild -project /Users/vgracanin/projects/core.ui.ios/Carthage/Checkouts/lottie-ios/Example/lottie-swift.xcodeproj CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES -list) failed with exit code 74: 2022-08-11 14:53:06.959 xcodebuild[5997:2398846] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore 2022-08-11 14:53:06.959 xcodebuild[5997:2398846] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore xcodebuild: error: Unable to read project 'lottie-swift.xcodeproj' from folder '/Users/vgracanin/projects/core.ui.ios/Carthage/Checkouts/lottie-ios/Example'. Reason: Project /Users/vgracanin/projects/core.ui.ios/Carthage/Checkouts/lottie-ios/Example/lottie-swift.xcodeproj cannot be opened because it is missing its project.pbxproj file.

github-actions[bot] commented 2 years ago

This issue is stale because it is marked "can't reproduce" and has had no activity in the past week. Please comment with additional information, or this issue will be closed due to inactivity in one week.

rachit-anurag commented 1 year ago

This issue is still reproducible for Xcode 14.1 with Carthage 0.38.0 for the Lottie 3.4.1