Closed moyus closed 4 years ago
Package | Diff | ESM | Prev ESM | CJS | Prev CJS |
---|---|---|---|---|---|
core | +0.0% | 566.56 KB | 566.49 KB | 708.61 KB | 708.54 KB |
Compared to master. File sizes are unminified and ungzipped.
View raw build stats
{
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 580089,
"lib": 725544
},
"forms": {
"esm": 37350,
"lib": 49298
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
}
{
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 580157,
"lib": 725612
},
"forms": {
"esm": 37350,
"lib": 49298
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
}
@moyus looks like this breaks getInputProps
tests as several of the expected props are wrong. Would another approach be to update partitionFieldProps
such that prefix
and suffix
are included in the inputProps
it generates?
@williaster fixed, please take a look.
to: @williaster @alecklandgraf
Description
BaseInput
inAutocomplete
doesn't receivehasPrefix
andhasSuffix
props before, which would cause style bug with<Prefix />
and<Suffix />
.The
hasPrefix
andhasSuffix
condition check is copied frompartitionFieldProps()
function.Motivation and Context
Fix style bug.
Testing
Looks good in storybook.
Screenshots
Before:
After:
Checklist