update(FormField): Update compact spacing in styles

monicapharm commented 4 years ago

to: @williaster @alecklandgraf

Description

This PR updates compactSpacing of the FormField styles from 16px to 12px, which is used for CheckboxController and RadioButtonController default spacing.

Motivation and Context

For Checkboxes and RadioButtons, 16px between each options looks good when there are subtitles, but is too spacious when there are no subtitles, and 12px is just right and provides a nice compromise that works regardless of whether there are subtitles.

And these changes are approved by the Lunar committee earlier this year.

Testing

Tested with local storybook.

Screenshots

Before (16px):

After (12px):

Before (16px with subtitles):

After (12px with subtitles):

Checklist

My code follows the style guide of this project.
I have updated or added documentation accordingly.
I have read the CONTRIBUTING document.

alecklandgraf commented 4 years ago

I'm checking with design to make sure there's no conflict with this.

williaster commented 4 years ago

hey @monicapharm, we can't run proper CI tasks on forks, so you'll need to clone the repo and create a branch with the airbnb origin 😞 I'll DM you with instructions for access.

jpdanks commented 4 years ago

@alecklandgraf yep! https://git.musta.ch/airbnb/solar/issues/875

monicapharm commented 4 years ago

Will close this PR, and created a new one. https://github.com/airbnb/lunar/pull/395

airbnb / lunar