airbnb / lunar

🌗 React toolkit and design language for Airbnb open source and internal projects.
MIT License
464 stars 77 forks source link

fix(ImageViewer): Only call document.preventDefault() when dragging #403

Closed apiel51 closed 4 years ago

apiel51 commented 4 years ago

to: @williaster @alecklandgraf

Description

document.preventDefault should only be called when dragging is true, otherwise it's impossible to highlight text and in the document

Motivation and Context

Running into this error in Torch

Testing

Tested locally in Storybook, added a text component above <ImageViewer />, tried to highlight and it didn't work. After this change, highlighting worked.

Screenshots

No visual diff

Checklist

airbnb-bot commented 4 years ago

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core -0.0% 567.33 KB 567.33 KB 709.46 KB 709.46 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580946,
    "lib": 726483
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580945,
    "lib": 726482
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}