airbnb / lunar

🌗 React toolkit and design language for Airbnb open source and internal projects.
MIT License
464 stars 77 forks source link

update(ModalInner): refactor with hooks #407

Closed moyus closed 4 years ago

moyus commented 4 years ago

to: @williaster @alecklandgraf

Description

Refactor ModalInner component into functional component with hooks.

Motivation and Context

Currently, the innerStyleSheet prop of Modal is not working, because ModalInner not support customized stylesheet. In order to support it, we need to refactor ModalInner component into functional component with hooks.

Testing

Screenshots

There is no UI change.

Screen Shot 2020-10-27 at 3 43 10 PM

Checklist

airbnb-bot commented 4 years ago

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core -0.1% 566.86 KB 567.33 KB 709.87 KB 709.46 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580945,
    "lib": 726482
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580467,
    "lib": 726903
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}