MvRx at Airbnb utilities

airbnb / mavericks

Mavericks: Android on Autopilot

https://airbnb.io/mavericks/

Apache License 2.0

5.83k stars 500 forks source link

MvRx at Airbnb utilities #112

Open filipwiech opened 6 years ago

filipwiech commented 6 years ago

Hi,

Looking through the wiki, more specifically "MvRx at Airbnb" page, I found some things that look really useful and convenient, namely the Fragments/MvRxFragments class for easy registering and creating fragments (even without a need for creating our own activity) with optional cross-module access, showFragment/showModal for fragment navigation and finally MvRxLauncher for starting fragments from launcher shortcuts. Is there any possibility for open sourcing those functionalities and sharing them with the community?

I understand that perhaps this is out of scope for the core MvRx, but maybe it could be released as an extension module?

elihart commented 6 years ago

I would like to release this as a separate module. This code is not as stable - I would like to keep developing the API's and develop it more internally first though. Maybe sometime next year though.

If you're really interested we could probably share it as a gist for now

qbait commented 6 years ago

Gist would be great. Thanks @elihart for your work!

filipwiech commented 5 years ago

@elihart Thank you for the quick response, I'm really looking forward to this! In the meantime a gist of an early version would be very appreciated.

filipwiech commented 5 years ago

Hi, is there any update on this (module release and/or gist snippets)?

elihart commented 5 years ago

No updates yet, but still something we would like to do in the future

gpeal commented 5 years ago

@elihart is there anything still there that would be worth open sourcing as part of this issue?

elihart commented 4 years ago

We are working on a new inter-module navigation system that can potentially be open sourced, it would be great to release if possible

Zoha131 commented 4 years ago

@elihart is there any update on this issue? Can we expect any update by March 2020?

elihart commented 4 years ago

From the comment above asking for this:

MvRxLauncher is actively being added in another PR. it is already working and visible in that branch and will be released as an alpha release soon
showFragment/showModal are not really anything. They are just functions to a base Fragment class that take a fragment as an argument and show it. The modal vs fragment thing is just a pattern we use to change the entry animation, but you can customize that however you want.
The navigation system I recently mentioned is not built yet. I can share a gist of the older MvRxFragments soon

elihart commented 4 years ago

Here is an example of a system for loading Fragments: https://gist.github.com/elihart/74e465676ff6663729f52690661e37e0

It has a few MvRx specific things (like how arguments are handled), but for the most part stands alone from MvRx (which is why it's not part of this library).

This is an incomplete example, it assumes you have base classes for your fragment and activities which are not provided, but which you should be able to figure out easily enough

jpventura commented 4 years ago

@elihart internally at Airbnb, will you keep this loading system for also refactor to Jetpack Navigation? #351