search

airbnb / mavericks

Mavericks: Android on Autopilot
https://airbnb.io/mavericks/
Apache License 2.0
5.82k stars 500 forks source link

Koin viewmodels' injection #339

Open kaganovych opened 4 years ago

kaganovych commented 4 years ago

I want to use Koin's extension functions for viewmodels' injections. Is there a way not to write MvRxViewModelFactory and use all the advantages of Koin? It's not very convenient to manually inject all of the dependencies into viewmodel through Factory.

dmytroreutov commented 4 years ago

Facing same issue. Should be upvoted

gpeal commented 4 years ago

@Jorikua @dmytroreutov At Airbnb and Tonal, we use dagger so that is where we have put the most effort. There is a dagger sample module now. Feel free to take a look and see if you can adapt it for koin. Fair warning though, we will probably not have the time to investigate koin integration ourselves though.

However, if changes are necessary to make it work well, we might consider it depending on what is necessary.