search

airbnb / mavericks

Mavericks: Android on Autopilot
https://airbnb.io/mavericks/
Apache License 2.0
5.79k stars 495 forks source link

Add support for RxJava3? #352

Open Dugin123 opened 4 years ago

Dugin123 commented 4 years ago

is any plan to support RxJava3?

gpeal commented 4 years ago

@BenSchwab @elihart This might be a good opportunity to the coroutines defualt + rxjava2 and rxjava3 extension libraries. What do you think?

Dugin123 commented 4 years ago

I prefer RxJava than coroutines. I think RxJava is more powerful and fitable functional programming. what do you think below structure? core+rxjava3 core+rxjava2 core+coroutines?

Anyway, regardless of module structure, RxJava3 has released official ver, so I hope it will be support.

elihart commented 4 years ago

Yes, I think this would tie in nicely to split extension libraries for these options. I would think that an extension library for rxjava3 would be pretty simple once we have one for rxjava2.

jpventura commented 4 years ago

@Dugin123 RxJava 2.x officially is at maintenance mode.

Thus we could piggyback coroutines refactor to simply offer 3.x built over extensions when JetBrains officially support it (see #347).

Dugin123 commented 4 years ago

@jpventura Now JetBrains support kotlinx-coroutines-rx3.

renaudcerrato commented 3 years ago

RxJava2 is in maintenance mode and support will stop on March 1st 2021 (source). Migrating is easy, will you accept a PR ?

elihart commented 3 years ago

Yes, if you look at the 2.0 release branch (https://github.com/airbnb/MvRx/tree/release/2.0.0) there is a mvrx-rxjava2 module. I think we would be open to a PR that adds an equivalent module for rxjava3. I imagine it would be pretty straightforward to mirror what is done in the rxjava2 module

JagadeeshBabuDamarasingu commented 1 year ago

hi @gpeal @elihart , I have opened a new PR #685 for this issue, please review