airbnb / mavericks

Mavericks: Android on Autopilot
https://airbnb.io/mavericks/
Apache License 2.0
5.85k stars 499 forks source link

Introduce Mavericks core module #635

Closed sav007 closed 2 years ago

sav007 commented 2 years ago

Move everything that could be Android platform agnostic into the core module.

Part of https://github.com/airbnb/mavericks/issues/632

codecov[bot] commented 2 years ago

Codecov Report

Merging #635 (afc5b4e) into main (f44e85b) will decrease coverage by 7.24%. The diff coverage is 18.38%.

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   55.06%   47.81%   -7.25%     
==========================================
  Files          53       49       -4     
  Lines        2508     2704     +196     
  Branches      326      289      -37     
==========================================
- Hits         1381     1293      -88     
- Misses        976     1279     +303     
+ Partials      151      132      -19     
Impacted Files Coverage Δ
.../airbnb/mvrx/compose/MavericksComposeExtensions.kt 0.00% <ø> (ø)
.../airbnb/mvrx/hilt/HiltMavericksViewModelFactory.kt 18.18% <0.00%> (ø)
...main/kotlin/com/airbnb/mvrx/mocking/MockBuilder.kt 22.01% <0.00%> (-11.73%) :arrow_down:
...c/main/kotlin/com/airbnb/mvrx/BaseMvRxViewModel.kt 71.53% <0.00%> (ø)
mvrx/src/main/kotlin/com/airbnb/mvrx/Mavericks.kt 66.66% <ø> (+46.66%) :arrow_up:
...main/kotlin/com/airbnb/mvrx/MavericksExtensions.kt 8.18% <0.00%> (ø)
.../kotlin/com/airbnb/mvrx/ViewModelStateContainer.kt 20.00% <20.00%> (ø)
.../main/kotlin/com/airbnb/mvrx/MavericksViewModel.kt 62.02% <68.08%> (+1.31%) :arrow_up:
...tlin/com/airbnb/mvrx/MavericksViewModelProvider.kt 90.47% <80.00%> (+1.76%) :arrow_up:
...tlin/com/airbnb/mvrx/mocking/KotlinReflectUtils.kt 66.66% <81.25%> (+8.04%) :arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed755e3...afc5b4e. Read the comment docs.

sav007 commented 2 years ago

@elihart fixed lint issue