search

airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse
MIT License
942 stars 151 forks source link

Add no-op service check #112

Closed schleyfox closed 5 years ago

schleyfox commented 5 years ago

For when you just want to will something in to health.

This check can be used when the presence of a running nerve process on a node is a reasonable enough proxy for likely health of the service the node is meant to be running. In our case, we're using nerve zk registration to expose some services over DNS, and we have a service that needs to have exposed DNS names before the service can properly start. It is a special case where it's better to maintain the registration than to accurately account for health.

Having a very simple no-op health check seems like a reasonable check to add.

igor47 commented 5 years ago

:+1: it might also be interesting to have a "process check" which doesn't directly interact with the process, but just checks to see if the process of a given name is running

schleyfox commented 5 years ago

Igor!!! 😍 That would also be a good check to add. In our use case, it won't help because the particular process crashes out if dns resolution on the names of its peers fails, which is a very annoying chicken and egg problem.

I will merge this a bit later once I have acquainted myself with the current internal deploy process for nerve.