search

airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse
MIT License
942 stars 151 forks source link

[service_watcher] make sure to check for $EXIT in sleep loop #53

Closed martinrhoads closed 9 years ago

martinrhoads commented 10 years ago

This PR fixes the issue that I describe in:

https://github.com/airbnb/nerve/issues/54

igor47 commented 9 years ago

i ended up using this PR as an excuse to add a lot of test coverage. this meant refactoring the service_watcher object to make it more testable in the first place. i would love some eyes on this!

cc @bobtfish @martinrhoads @nelgau

martinrhoads commented 9 years ago

yea!