airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse
MIT License
942 stars 151 forks source link

Added etcd hosts failover. #58

Open cloakedcode opened 10 years ago

cloakedcode commented 10 years ago

Allows multiple etcd nodes to be configured and rotates through until it successfully establishes a connection.

philips commented 9 years ago

lgtm

igor47 commented 9 years ago

hi @cloakedcode ; this PR needs a rebase now that #68 has been merged. also, i would not merge this because it breaks backwards compatibility of existing config files.

can you rework this to add etcd_hosts as a secondary parameter but still also accept the old host and port options? then you can just add what's in host and port to hosts and loop through all of them.

telmich commented 5 years ago

Hey! This looks very interesting! Is there any work going on in this issue?