airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse
MIT License
942 stars 151 forks source link

Fix etcd reporter #68

Closed bitglue closed 9 years ago

bitglue commented 9 years ago

The existing implementation was quite clearly a half-baked copy & paste of the zookeeper watcher with s/zookeeper/etcd. Update it to actually work.

Supersedes #55.

CONTRIBUTING.md requests pull requests to be made into the pull_requests branch, but that branch is a year old, so I'm requesting a merge to master.

philips commented 9 years ago

lgtm

bitglue commented 9 years ago

@igor47 any comments?

igor47 commented 9 years ago

looks great, thanks for the PR!