Merge the forks - Githubissues

airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse

MIT License

942 stars 151 forks source link

Merge the forks #71

Closed jolynch closed 9 years ago

jolynch commented 9 years ago

This should bring Yelp's fork back into line.

Major changes:

Reporters that use the same zookeeper hosts will share one underlying zookeeper connection
If watchers throw an exception, Nerve attempts to restart them instead of failing the whole process
Nerve can heartbeat to a file on disk in case it falls victim to the dreaded sched_yield
Added a weight key that is saved in the service data for synapse to use
(cleanup) Removed update_data method that is unused by nerve

jtai commented 9 years ago

LGTM, but I'll wait for @igor47 to weigh in.

Thanks!

igor47 commented 9 years ago

great, done with review. left a few comments, nothing major jumped out. fyi @jtai and @schleyfox this is up next after the synapse upgrade is rolled out

jolynch commented 9 years ago

I'm going to go ahead and merge this and start dogfooding at Yelp. If we come across any issues I can address in follow up changes.