Thread haproxy_server_options through from reporters

airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse

MIT License

942 stars 151 forks source link

Thread haproxy_server_options through from reporters #75

Closed jolynch closed 8 years ago

jolynch commented 9 years ago

This option can be used to enable custom server level options in the fronting haproxy instances, which allows things like declaring that a particular node is a backup or should be healthchecked a special way.

Synapse already partially supports this option and it will have full support once https://github.com/airbnb/synapse/pull/144 is merged.

Jaykah commented 8 years ago

I can confirm this is passing options to Zookeper successfully. One note though - if the config is changed to include those additional options and then a Nerve restart is done, a new node is created in Zookeeper, but the old ephemeral node does not disappear until manually removed.

jolynch commented 8 years ago

@Jaykah I'm going to merge this because I can't reproduce that bug. Which version of ruby, nerve, and zookeeper are you using? Are you sure that the old nerve process is no longer running?

@zhitaoli I can merge this now but I can't really get it into production to verify for at least a week (thanksgiving).

zhitaoli commented 8 years ago

@jolynch Awesome! Many thanks for the progress!