3xx status codes should mean success

airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse

MIT License

942 stars 151 forks source link

Closed jolynch closed 8 years ago

jolynch commented 8 years ago

Previously nerve considered 3xx to be failure, which is inconsistent with most other healthcheck systems (e.g. haproxy or nginx).

Should fix #77

jolynch commented 8 years ago

@igor47, @rickypai Do you guys have any opinions on this. If not I'm going to ship it.

evie404 commented 8 years ago

seems ok to me. update the test to include a 3xx case?

jolynch commented 8 years ago

@rickypai I don't believe there are any tests really ... which test are you thinking?

jolynch commented 8 years ago

I'm going to merge and follow up with a test when there are tests.