search

airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse
MIT License
942 stars 151 forks source link

Recover from bad zk connections #93

Closed jolynch closed 4 years ago

jolynch commented 7 years ago

Should fix #92

I think that we might need to somehow touch zk in zk_delete for this to really work, but WIP.

minkovich commented 6 years ago

@jolynch could you merge this? We just had this issue reoccur.

edroofs commented 6 years ago

Hello! No, i couldn't merge this

On 9 March 2018 at 20:53, minkovich notifications@github.com wrote:

@jolynch https://github.com/jolynch could you merge this? We just had this issue reoccur.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/airbnb/nerve/pull/93#issuecomment-371891560, or mute the thread https://github.com/notifications/unsubscribe-auth/AcG6X4ZyYV5fDki_sPXMnmSQaCnMfYenks5tcsGkgaJpZM4NMccW .

jolynch commented 6 years ago

@minkovich yea let me dig this back up, I'll try to get this merged this week.

panchr commented 4 years ago

Closing because already fixed in #113.