search

airbnb / nerve

A service registration daemon that performs health checks; companion to airbnb/synapse
MIT License
942 stars 151 forks source link

Adding `statsd` dependency and exporting some stats #97

Closed juchem closed 6 years ago

juchem commented 6 years ago

Adding support for exporting metrics through statsd. Also, exporting basic metrics about nerve's health and performance.

How it was tested: unit tests + manual run and checking exported metrics

Reviewer: @lap1817

cc @darnaut

lap1817 commented 6 years ago

Can you also add metric to the service_watcher? especially when it does report.ping?, reporter.up and reporter.down. Those are the most frequent nerve status change and may impact ZK read on the synapse side. So it will be useful to have them in DD. https://github.com/airbnb/nerve/blob/master/lib/nerve/service_watcher.rb#L116

juchem commented 6 years ago

yes, I'll add that

juchem commented 6 years ago

@lap1817 I've made changes to service_watcher.rb. That should cover service watcher, reporters and service checks.

lap1817 commented 6 years ago

LGTM