search

airbnb / polyglot.js

Give your JavaScript the ability to speak many languages.
http://airbnb.github.io/polyglot.js
BSD 2-Clause "Simplified" License
3.71k stars 208 forks source link

Please mention in the documentation `smart_count` is obligatory for pluralization to work #146

Closed chepe263 closed 4 years ago

chepe263 commented 4 years ago

Reading the documentation, smart_count seems like a generic name for a value that will be interpolated. People might get the idea the name for the value to be interpolated can be anything (num_messages, ammo_amount, etc) that suits the context of translation strings.

spikebrehm commented 4 years ago

PRs accepted :)

chepe263 commented 4 years ago

README.md in master and index.md in gh-pages are the only places where it needs updating, right?

I would like to know the right places before starting with the pr

chepe263 commented 4 years ago

pr #147 for README.md in master branch pr #148 for index.md in gh-pages branch

ljharb commented 4 years ago

gh-pages is only updated on release; only the master branch needs updating.

chepe263 commented 4 years ago

the pr was merged, closing the issue...