Closed SoSolife closed 4 months ago
Thanks! Could you also provide test cases that would fail without this change, ideally in all of the affected languages?
Like Project navidrome, the Chinese translation file in Line 346 would judge the value that returns 0
or 1
to select which value to print.
Here is the test which selects two items but shows singular.
I think the better way to handle this is something like count === 1 ? t('single') : t('multiple')
in your site, as opposed to in this library, since the pluralization here is meant to only be in a grammatical sense.
Chinese has pluralization though the noun may not change to nouns like
1个人
and2个人
that one person and two persons in English. I get the problem in this which usessmart_count
to sum because the codereturn 0
in all values.