airbnb / polyglot.js

Give your JavaScript the ability to speak many languages.

http://airbnb.github.io/polyglot.js

BSD 2-Clause "Simplified" License

3.71k stars 208 forks source link

Arabic #71

Closed adamhooper closed 8 years ago

adamhooper commented 8 years ago

This pull request is built atop #69; #69 should be merged first.

ljharb commented 8 years ago

69 will never be merged; Intl support is not a practical requirement - note that this package needs to work in both browsers (down to IE 8) and node (down to 0.10).

I'd love to support Arabic pluralization without requiring Intl support, though!

adamhooper commented 8 years ago

If I were to rebase without the Intl.NumberFormat, would that be acceptable? That would show Arabic numerals (i.e., the ones we use in English) alongside Arabic text (i.e., squiggly right-to-left script). It would appease Travis, too.

ljharb commented 8 years ago

How off-putting would that be to an Arabic language speaker? I know that English numerals often appear alongside Japanese characters, for example, even though the kanji numerals work just as well - is something similar true in Arabic?

adamhooper commented 8 years ago

I hope you don't mind, I did git push --force.

ljharb commented 8 years ago

Not at all! Everything should always be force pushed.

adamhooper commented 8 years ago

I have no idea -- I'm just a perfectionist ;)