GraphQL example errors out

airbnb / react-sketchapp

render React components to Sketch ⚛️💎

http://airbnb.io/react-sketchapp/

MIT License

14.94k stars 820 forks source link

Closed jemgold closed 7 years ago

jemgold commented 7 years ago

Expected behavior:

/examples/profile-cards-graphql when installed, executes correctly.

Observed behavior:

in Console.app:

How to reproduce:

cd ~/examples/profile-cards-graphql
npm i
npm run watch
skpm link .

then execute the plugin in a new document in sketch

Sketch version: 43 (38999)

reported by @ChristopherBiscardi — I can't reproduce it 🤔

jemgold commented 7 years ago

Oops - actually I can replicate it - the GraphQL example is currently crashing Sketch 😅

I'm going to assume it's something in skpm or sketch-module-fetch-polyfill - @darknoon can you help me read this crash log? https://gist.github.com/jongold/6235d9d92398e658b10e063cf734542c

cc @mathieudutour

mathieudutour commented 7 years ago

no, the error is in react-sketchapp, you can print the allProfiles but the render method is creashing

screen shot 2017-04-25 at 20 13 28

mathieudutour commented 7 years ago

specifically, it's when rendering the Avatar that it's crashing

jemgold commented 7 years ago

@mathieudutour oh wow my bad - my brain isn't switched on. Thanks for finding it.

There was an image being fetched that didn't exist - fixed now.

Closing this, and making #13 high priority.