search

airbnb / react-sketchapp

render React components to Sketch ⚛️💎
http://airbnb.io/react-sketchapp/
MIT License
14.95k stars 824 forks source link

Add shadowInner style to docs #490

Closed macintoshhelper closed 4 years ago

macintoshhelper commented 4 years ago

Add shadowInner to styling.md docs README.

Code reference: https://github.com/airbnb/react-sketchapp/blob/cee20156d3795c3e4899e746aafde7cd22a149e6/src/jsonUtils/style.ts#L89

Related issues/PRs

160

mathieudutour commented 4 years ago

Maybe, because it's a sketch specific style field, it should be in its own section? This section is more like the list of the RN properties that are(n't) supported by react-sketchapp. What do you think?

macintoshhelper commented 4 years ago

👍 Was thinking of that. Should I move shadowSpread too, since that's not supported by React Native? (shadow* props are iOS only in React Native, but RN docs clarify that)

mathieudutour commented 4 years ago

Ah yep good catch

macintoshhelper commented 4 years ago

I moved the shadows to a new shadow section (instead of layout), to mirror the React Native docs, and added a note of react-sketchapp only ones. ~Or maybe it would make more sense to have a new react-sketchapp only styles section?~

I created a new React Sketch.app only styles section, and linked to it from the shadows, hopefully that's clear enough.

mathieudutour commented 4 years ago

Perfect, thanks

macintoshhelper commented 4 years ago

Np, thanks for cleaning up the file/text. I had left in extra spacing in the table for stylistic purposes to keep the width aligned for GitHub, but the website GitBook makes the tables full width anyway, so looks good 🙂.