search

airbnb / react-sketchapp

render React components to Sketch ⚛️💎
http://airbnb.io/react-sketchapp/
MIT License
14.94k stars 821 forks source link

Quickstart is not working #88

Closed dstroot closed 7 years ago

dstroot commented 7 years ago

👋 Hello! Thanks for contributing. Please use the template that matches your intention

Expected behavior:

Quickstart would do something other than fail. :)

Observed behavior:

npm run render

> basic-setup@1.0.0 render /Users/Dan/Code/react-sketchapp/examples/basic-setup
> skpm build --watch --run

🖨  Copied src/manifest.json in 6ms
TypeError: null is not an object (evaluating 'context.document.currentPage')
line: 9229
column: 114

How to reproduce:

git clone https://github.com/airbnb/react-sketchapp.git
cd react-sketchapp/examples/basic-setup && npm install
npm run render

e.g. Follow quickstart steps...

Sketch version:

43.2

Please attach screenshots, a zip file of your project, and/or a link to your github project

I just cloned this repo.

jemgold commented 7 years ago

@dstroot you currently have to have Sketch open to a new document - fix coming soon, sorry for the confusion!

dstroot commented 7 years ago

Got it! Thanks!

On May 6, 2017, at 11:00 AM, Jon Gold notifications@github.com wrote:

@dstroot you currently have to have Sketch open to a new document - fix coming soon, sorry for the confusion!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jemgold commented 7 years ago

🙌

jonmadison commented 4 years ago

oof, still an issue. made a guess on a fix, but still would be great to add that to the documentation