search

airbnb / react-with-styles-interface-aphrodite

Interface to use react-with-styles with Aphrodite
MIT License
54 stars 14 forks source link

Support automatic RTL styling as an option #14

Closed majapw closed 7 years ago

majapw commented 7 years ago

In the same way that we have an option that removes the !important flag from our styles, it would be neat if we could integrate https://github.com/kentcdodds/rtl-css-js or something similar to automatically flip things like

* text-align
* float
* margin
* padding
* positioning
* border
* border-radius
* transforms
* background-positions

in order to support RTL languages. This seems like an implementation detail that would make sense at the interface layer and could be exported as an alternative to the main interface.

What do y'all think? @yzimet @lencioni

yzimet commented 7 years ago

I'm in favor!

lencioni commented 7 years ago

@majapw is there any more work that needs to be done on this?

majapw commented 7 years ago

I do not believe so!

On Tue, Sep 12, 2017, 4:26 PM Joe Lencioni notifications@github.com wrote:

@majapw https://github.com/majapw is there any more work that needs to be done on this?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/airbnb/react-with-styles-interface-aphrodite/issues/14#issuecomment-328974422, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUdtc7HN8X-GhkIPJeIGeIeCptqj-feks5shukLgaJpZM4OWI07 .

lencioni commented 7 years ago

This should be in v2.0.0+