search

airbnb / react-with-styles-interface-aphrodite

Interface to use react-with-styles with Aphrodite
MIT License
54 stars 14 forks source link

An in-range update of aphrodite is breaking the build 🚨 #19

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 1.2.4 of aphrodite just got published.

Branch Build failing 🚨
Dependency aphrodite
Current Version 1.2.3
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As aphrodite is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/airbnb/react-with-styles-interface-aphrodite/builds/274724297?utm_source=github_status&utm_medium=notification)
Commits

The new version differs by 7 commits.

  • f7c37e5 1.2.4
  • d048293 Update changelog for upcoming 1.2.4 release
  • 86135d6 Remove note about murmurhash license from readme
  • 46a73de Update changelog for 1.2.2, 1.2.3
  • 43b3d87 Merge pull request #263 from gilbox/gil-fix-styleDefinitions-null-values
  • a47ff8c Fix injectAndGetClassName and ignore null values in styleDefinitions
  • 7f9f602 Minify combined class names (#248)

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 1.2.3 your tests are passing again. Downgrade this dependency 📌.

ljharb commented 7 years ago

Closed in #20.