search

airbnb / react-with-styles-interface-aphrodite

Interface to use react-with-styles with Aphrodite
MIT License
54 stars 14 forks source link

no-important #5

Closed gilbox closed 7 years ago

gilbox commented 7 years ago

The only difference is the import at line 1.

NOTE: I still need to look at removing inline styles for amp. Planning to do that in a separate PR.

@lencioni

ljharb commented 7 years ago

Given that's the only difference, can we refactor so there's not duplicated code?

gilbox commented 7 years ago

ping @ljharb

ljharb commented 7 years ago

Awesome, this looks great! I'll defer to @lencioni for final review.

gilbox commented 7 years ago

ping @lencioni

gilbox commented 7 years ago

@lencioni or @ljharb any idea what I can do about this CI error?

https://travis-ci.org/airbnb/react-with-styles-interface-aphrodite/jobs/195969833

It is failing because CI doesn't build lib/.

gilbox commented 7 years ago

ping @lencioni

gilbox commented 7 years ago

ping @lencioni

gilbox commented 7 years ago

@lencioni I added tests for !important