search

airbnb / rheostat

Rheostat is a www, mobile, and accessible slider component built with React
MIT License
1.69k stars 189 forks source link

[fix] Move theme registration to src #182

Closed philipfweiss closed 6 years ago

philipfweiss commented 6 years ago

Addresses https://github.com/airbnb/rheostat/issues/181. Moves the theme registration helper functions into src, so they will be compiled during the build step. Also updates the callsites of these functions to point into lib/utils/<x>, as desired.

Keeps a copy of these files in scripts/utils as well, for backwards-compatibility. These files should be removed at the next major version update.

philipfweiss commented 6 years ago

@ljharb I believe public interface being exposed hasn't changed, so this should be semver-minor.

ljharb commented 6 years ago

@philipfweiss all accessible files are part of the public interface.

philipfweiss commented 6 years ago

@ljharb Ok! Based on a discussion with @majapw, we will keep a copy of the files in scripts/utils, which should be removed at the next major version update.

majapw commented 6 years ago

Looks great to me!