search

airbnb / rheostat

Rheostat is a www, mobile, and accessible slider component built with React
MIT License
1.69k stars 189 forks source link

@types/rheostat values #277

Closed ghost closed 4 years ago

ghost commented 4 years ago

I have created a PR on @types/rheostat to change the types of the value state and props. Currently the types will accept any length of numbered array. number[]. As I understand this will only ever contain 2 values - min and max. Therefore I propose to change this to [number, number].

I have opened this issue to get some feedback on this PR and create some additional context around the issue.

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43191

ljharb commented 4 years ago

Thanks, I'll take a look; closing this here, though, since this package doesn't maintain types.