search

airbnb / rheostat

Rheostat is a www, mobile, and accessible slider component built with React
MIT License
1.69k stars 189 forks source link

remove unnecessary var from numerator and denominator in geometic equation and tidy up /algorithm code #281

Open albertstill opened 4 years ago

albertstill commented 4 years ago

There is an unnecessary var being used in the geometric equation, I've removed it and tidied up the code. Note there are tests to cover the geometric equation, them passing helps prove it's the same equation with this var removed.

Here is some handwritten maths explaining why the max need not live at the top and bottom of the fraction, it just cancels out. I start with what we used to have and finish with what this PR changes to.

IMG_20200521_171308

albertstill commented 4 years ago

Can we merge this now?

albertstill commented 4 years ago

What about now?