search

airbnb / rheostat

Rheostat is a www, mobile, and accessible slider component built with React
MIT License
1.69k stars 189 forks source link

RTL Support Doesn't Work #282

Open mfalthaw opened 4 years ago

mfalthaw commented 4 years ago

Thanks for your contributions and for supporting RTL!

We were testing rheostat slider and we encountered issues with RTL. (see gif below)

slider_rtl

Slider direction is flipped (opposite to the mouse movement direction)

relates to #235

richardgreg commented 3 years ago

Hi, I would like to work on this issue.

richardgreg commented 3 years ago

@ljharb is this repository still actively maintained and used?

ljharb commented 3 years ago

@richardgreg yes. You don't have to ask to work on an issue; anything with a "help wanted" label is up for grabs.

a15n commented 1 year ago

Hello @ljharb and @richardgreg I've fixed the RTL issue on localhost. It required quite a few changes like this within <Slider/> ....

Screenshot 2023-01-10 at 5 57 39 PM

I've verified that this works for each RTL Story. Unfortunately, when I try to git push to make a pull request I get this error....

remote: Permission to airbnb/rheostat.git denied to a15n.
fatal: unable to access 'https://github.com/airbnb/rheostat.git/': The requested URL returned error: 403

I'm looking into that now, but thought I'd revive this issue.

ljharb commented 1 year ago

I wouldn’t expect a push to work on https; you may need to try ssh - but either way, if what you have builds on #285, can you push a branch to your fork, and i can pull in your changes to that PR?

a15n commented 1 year ago

I've made this demo PR, which highlights that RTL auto-flipping is no longer happening. It hard-codes the correct left/right direction in the JS, but it cannot change the CSS. Regardless, this PR is just demonstrating that RTL would work again if the auto-flipping were working.

@ljharb, @rcourtie, @majapw any idea what may have caused RTL auto flipping to stop working sometime after it was introduced in 2019?