airbnb / rheostat

Rheostat is a www, mobile, and accessible slider component built with React
MIT License
1.69k stars 189 forks source link

Assign disabled class to defaultProgressBar #284

Open pavloko opened 3 years ago

pavloko commented 3 years ago

It looks like DefaultProgressBar wasn't assigning a disabled class name for disabled prop.

I've updated it to mirror the DefaultHandle class naming pattern and now progress bar correctly applies DefaultProgressBar__disabled class name when disabled prop is true.

Before

Screenshot 2021-02-04 at 17 45 31

After

Screenshot 2021-02-04 at 17 45 47
pavloko commented 3 years ago

I'm not exactly sure why tests are failing. It looks like some issues with node or react version. I'd appreciate if somebody could point me in the right direction.