search

airbnb / rheostat

Rheostat is a www, mobile, and accessible slider component built with React
MIT License
1.69k stars 188 forks source link

PropType warnings for not required props #288

Open daryaskopyuk opened 3 years ago

daryaskopyuk commented 3 years ago

In the latest version of rheostat I receive prop type warnings for not required props that are not passed to <Rheostat /> component. These props are: handle, background, progressBar.

For example, for the component...

<RangeSlider
   min={0}
   max={100}
   values={[min, max]} 
   snap={true}
/>

...there are warnings like this:

Screenshot 2021-11-29 at 10 09 50

As far as we investigated this issue, these warnings appear when react-with-styles dependency has version 4.2.0. When we pin it to 4.1.0 warnings are not present.

ljharb commented 3 years ago

cc @noratarano @lencioni; v4.2.0 of react-with-styles caused breaking changes in react-dates, and appears to be doing the same here. can someone look into that?