search

airbnb / smartstack-cookbook

The chef recipes for running and testing Airbnb's SmartStack
MIT License
245 stars 45 forks source link

Allow configurable path to `service` #13

Open tdooner opened 10 years ago

tdooner commented 10 years ago

Hello! First, thanks for this awesomely configurable cookbook. It has made it possible for me to find the joy of smartstack without needing to configure barely anything to begin with.

I know this cookbook is intended for Ubuntu audiences only, but we're looking at using it on CentOS. Only one snag to be found (so far?): the path to the service executable is different so SmartStack cannot restart haproxy.

This PR is a quick hack allowing a different path based on node['platform'], and for other platforms to be able to configure it via an attribute. I'd be happy to rewrite a different way if you think of a better way.

Also, is there a convenient way to run the test suite against this? I did some minimal verification locally but some continuous integration here could go a long way.

Thanks!

spuder commented 9 years ago

Looks like this has been open for a while. Anything stopping this from being merged?

tdooner commented 9 years ago

@spuder It seems to me that this repo is basically dead. My company, Brigade, maintains a fork at https://github.com/brigade/smartstack-cookbook which works for us in our rbenv / CentOS 7 environment. You're welcome to give it a try if you want, but YMMV.

spuder commented 9 years ago

Thanks for letting me know. I'm also evaluating consul. It appears to do the same thing.

tdooner commented 9 years ago

We're also looking into that. FWIW, even if we end up using Consul, I think it's likely we'll continue using synapse. It's really good at interacting with haproxy.

Fortunately, synapse has an abstraction around the backends it supports, so it should be possible to write a consul watcher as others have done for Etcd and Marathon (we're running that marathon PR in production)