Open Ryxias opened 3 years ago
I really like the changes here to the aggregation filter and also the additional fields.
To confirm was the intent in the CC to see if they should also be added to the Jira_v2 output.
Also in hindsight I wonder if supporting both auth methods in the same output behind a boolean may be better than two distinct outputs.
Yeah it was kind of an "FYI" since I knew you wrote a lot of the JIRA v2 integration. Admittedly we didn't sync the v2 internally yet so I actually forgot it existed on the OSS repo; only just noticed it when I synced these JIRA changes out.
And yeah, I took a cursory glance over the JIRA integration and I see the main difference is the auth; v1 uses username/password login whereas v2 uses api key in basic auth header. Since they both use REST API v1/v2 I think would be worth DRYING it out. I'll think about doing that if I have time
PS this is 🔥 Just pulled this in & Dry'd out the config in #1333
to: @ryandeivert @chunyong-lin cc: @gavinelder cc: @airbnb/streamalert-maintainers
Changes
ClientSide SSL Verification
To enable this, simply put
yes
in the newssl_verify
output parameter.Aggregation Additional Filter
Can also use other fields like
created > startOfWeek(-1w) AND status != Resolved
or the like. It depends on your JIRA project's specific configurations. You might have some crazy custom field likecustom_field_10101 = "Low"
. Etc.To enable this, simply put the query string into the
aggregation_additional_jql
output parameter.Additional Fields
To enable this, provide the json-encoded string representation of the dict. Because the parameter store stores everything as a JSON string you'll have to escape quotes.
Testing
Deployed internally