Fix LegendThreshold - Githubissues

ZachBarbre commented 4 months ago

Changed how the labelTransform get an upper and lower value to get the color out of the threshold scale.
This should guarantee a larger or smaller number than the upper and lower bounds is passed into the scale function to retrieve the correct color.
Remove the logical OR from the scale() input. It should now never be undefined and this was the cause of a bug if the the lower bound was 1 making value falsy.
Because I can't help but make eslint happy, added a type to the domain.

Issue #1828

github-actions[bot] commented 4 months ago

🎉 This PR is included in version v3.10.3 of the packages modified 🎉

hshoff commented 4 months ago

Confirmed fixed with @visx/legend@3.10.3

before	after

airbnb / visx