airbnb / visx

🐯 visx | visualization components
https://airbnb.io/visx
MIT License
19.4k stars 712 forks source link

Type annotation incomplete for visx/geo fitExtent/fitSize #1856

Open aendra-rininsland opened 3 months ago

aendra-rininsland commented 3 months ago

These lines for the fitExtent and fitSize props have ExtendedFeatureCollection commented out for some reason, which is preventing me from passing a FeatureCollection to my Projection component in TypeScript.

https://github.com/airbnb/visx/blob/master/packages/visx-geo/src/projections/Projection.tsx#L71 https://github.com/airbnb/visx/blob/master/packages/visx-geo/src/projections/Projection.tsx#L76

AFAICT it works fine to pass a FeatureCollection to; I'd submit a PR fixing those lines but given they're commented out was thinking there might be another reason why that I'm missing.