search

airbrake / airbrake-python

Airbrake Python
MIT License
51 stars 24 forks source link

Send environment variables in payload #67

Closed zachgoldstein closed 7 years ago

zachgoldstein commented 7 years ago

Closes: https://github.com/airbrake/airbrake-python/issues/52

zachgoldstein commented 7 years ago

Looks like this sort of feature has been pulled out of phpbrake and the ruby notifier. I'm starting to think that we should only do this if the user explicitly requests it. So we'd have a whitelist of keys that would be pulled out of the env and sent. I feel like this would be safe by default since it doesn't send anything, but still gives users the flexibility to do this.

zachgoldstein commented 7 years ago

I'm going to ditch this PR. If it's been pulled from the php and ruby notifiers, we probably shouldn't bother with it here. I'm going to keep a branch kicking around in case things change.