search

airbrake / airbrake-python

Airbrake Python
MIT License
51 stars 24 forks source link

Asyncio support? #94

Closed hzlmn closed 5 years ago

hzlmn commented 5 years ago

Hi thanks for good tool and battery!

Asyncio/aiohttp stack is rapidly growing in usage and it will be really nice if library add support for async transport.

If you consider it as an addition i can create PR.

phumpal commented 5 years ago

@hzlmn good idea. Can we maintain backwards compatibility for Python 2.7? It appears the latest releases for asyncio/aiohttp only support Python 3.3 which was deprecated in #91.

Have you seen our "new" Python notifier https://github.com/airbrake/pybrake? It supports Python 3.4+

hzlmn commented 5 years ago

@phumpal Nope, only python 3.3 and later. Yep i found new version after i created an issue. pybrake has some async support as i can see, but it uses ThreadPool approach so maybe it would be good addition to provide "native" asyncio support and move this issue there.

phumpal commented 5 years ago

@hzlmn perfect, that sounds great. Thanks! Let's close this issue for now.

Heads up @vmihailenco and @anmic