search

airbrake / pybrake

Python exception notifier for Airbrake
https://airbrake.io
Other
37 stars 17 forks source link

get_full_name optional on AbstractBaseUser #267

Open rcjohnson opened 1 year ago

rcjohnson commented 1 year ago

https://github.com/airbrake/pybrake/blob/f50658879447d142e490bd23297c34144d62222e/src/pybrake/middleware/django.py#L124 -> references get_full_name(), but per https://docs.djangoproject.com/en/4.2/topics/auth/customizing/ get_full_name is optional. Either update the documentation for Airbrake to make it clear that this method must be implemented, or better, update this line to check for the method and workaround cases when get_full_name is not implemented (e.g. teams with custom user models.)

rcjohnson commented 1 year ago

For context, if this method is missing Airbrake throws an error when trying to log errors seemingly preventing it from actually logging to Airbrake.