airbreather / Gavaghan.Geodesy

A C# implementation of Vincenty's formulae
Other
9 stars 8 forks source link

Are GetHashCode() Changes An Improvement? #1

Open airbreather opened 9 years ago

airbreather commented 9 years ago

3a696d5 changed GetHashCode methods of all value types, including some that appeared to have had at least some thought put into them, to a cookie-cutter implementation.

Is this better than it was before? Worse? To find out conclusively, real-world data (or similar) will be needed.

juliusfriedman commented 3 years ago

I feel its better, would also use HashCode.Combine when possible as well as use a Vector which gives you the extra components and the GetHashCode implementation for free.