Closed lacqui closed 6 years ago
Can you please help me understand why the existing code is insufficient? From my reading of your change, it looks like it's not doing anything that this block immediately following your changes wouldn't take care of.
Are you saying that the code inside the try
is incorrect in cases where it doesn't throw? If so, why not just delete the try
/catch
block altogether?
BTW is there a reason that MD5s are organized by size rather than filename, or that extracts are done into random names? I have a local patch for extraction directories that makes debugging easier for me.
A few things going on here:
OK now I see what's going on here. I'm going to look some more at the code. I was actually looking for a way of dealing with the second part of #21 when I saw this.
Understanding where you were going with this, I'm going to close this PR.
Attempt to fix #44
BTW is there a reason that MD5s are organized by size rather than filename, or that extracts are done into random names? I have a local patch for extraction directories that makes debugging easier for me.