search

airbug / airbug-chat

Better chat for developers
Other
0 stars 0 forks source link

SonarBug. SonarBug should check all of the logEventManagers during log rotations #103

Open sungchoi opened 11 years ago

sungchoi commented 11 years ago

@bneisler not sure how to QA this besides a unit test and/or code review Also. I'm still not convinced that this is necessary given that decrementMoveCount and OnceOn have been fixed. Side Note: I added code to move all of the folders inside of the logs/completed folder to the logs/toPackage folder because some folders were being left behind when sonarbug broke during development and there was no fallback for this situation.

sungchoi commented 11 years ago

@bneisler Writing a unit test now

sungchoi commented 11 years ago

@bneisler as I was writing this test, it became clear that is was not very clean. However, I tried to make the test as simple as possible and only test that updateLogEventManagers when through all of the logEventManagers. I mocked the logEventManagers and stubbed out the methods called internally by the method being tested (onceOn and moveCompletedFolderToToPackageFolderAndRemoveLogEventManager, but it's the fact that I had to do that that feels dirty to me. Thoughts? Advice?