airbus-cert / ttddbg

Time Travel Debugging IDA plugin
Apache License 2.0
550 stars 33 forks source link

IDA version 8.4 change of enum_member_t struct to edm_t in typeinf.hpp #17

Closed richardweiss80 closed 2 months ago

richardweiss80 commented 4 months ago

Dear Airbus CERT team,

enum_member_t is not used in IDA SDK v8.4 and was replaced for this version at least by edm_t.

Build was created with:

Build was tested with provided executable and its trace: ttddbg_test_multithread01

Recognition for finding the change is due to Mr. Josh Homan (Manager at Mandiant FLARE).

Thank you for your impressive work on this plugin. I hope to stay in touch!

Kind regards, Richard

0xeb commented 4 months ago

Thanks, Richard.

Some practical clarifications about the build notes. For IDA 8.2 and onwards, make sure to run CMake as such:

cmake ..\ttddbg -DIDA_SDK_PRO <the rest remains the same>

Otherwise, with this PR, it builds nicely with 8.4 SDK.

@richardweiss80 , probably you need an #ifdef around your new code changes so it builds also in prior version?

citronneur commented 2 months ago

Thanks @richardweiss80 for your PR. I will create a release version.